Pass action parameter to participants route when changing recipient by MelvinBot · Pull Request #84321 · Expensify/App

MelvinBot · 2026-03-05T20:08:11Z

Explanation of Change

In MoneyRequestConfirmationList.tsx, the navigateToParticipantPage function was not passing the action parameter when navigating to the participants step. This caused the route to default action to 'create' instead of preserving the actual action (e.g., 'submit'). As a result, when the user tapped the "To" field on the confirmation page during a "Submit it to someone" flow for a track distance expense, isMovingTransactionFromTrackExpense('create') returned false, which set includeSelfDM to true — incorrectly showing the self DM option in the participant list.

The fix passes the existing action prop as the 5th argument to ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(), so the participants step preserves the correct flow context.

Fixed Issues

$ #81003
PROPOSAL: #81003 (comment)

Tests

Create an unreported track distance expense (FAB > Track expense > Distance)
Enter start/stop points, save distance, fill out details and create the expense in self DM
Find the expense and tap "Submit it to someone"
Select any recipient (observe that self DM does not appear here)
On the confirmation page, tap the "To" field
Verify that self DM does NOT appear in the participant list

Verify that no errors appear in the JS console

Offline tests

N/A — This change only affects navigation route parameters. No network calls are involved in the fix.

QA Steps

Create an unreported track distance expense
Tap "Submit it to someone"
Select any recipient
On the confirmation page, tap the "To" field
Verify that self DM does NOT appear in the participant list
Verify you can still change the recipient normally

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — No UI changes, only route parameter fix

Android: mWeb Chrome

N/A — No UI changes, only route parameter fix

iOS: Native

N/A — No UI changes, only route parameter fix

iOS: mWeb Safari

N/A — No UI changes, only route parameter fix

MacOS: Chrome / Safari

Tested on web — after the fix, tapping the "To" field on the confirmation page during a "Submit it to someone" flow for a track distance expense correctly excludes self DM from the participant list.

When tapping the To field on the confirmation page during a Submit it to someone flow for track distance expenses, the action parameter was not being forwarded to the participants route. This caused it to default to create, which incorrectly included self DM in the participant list. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

situchan · 2026-03-05T20:08:44Z

@MelvinBot mark as ready for review

melvin-bot · 2026-03-05T20:10:19Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-03-05T20:10:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

melvin-bot · 2026-03-05T20:12:38Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #81003 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

codecov · 2026-03-05T20:18:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`61.70% <0.00%> (-0.64%)`	⬇️
... and 11 files with indirect coverage changes

github-actions · 2026-03-06T08:18:23Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T08:23:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84321.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-04b333d-5430cbd-9eba66f84415d5769f4f6c4deadc0b5869c2bc16/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-04b333d-5430cbd-40aca5860ad240782784277d27d7a632bce92337/index.html

Web 🕸️
https://84321.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T08:25:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T23:03:32Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:38:48Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned situchan Mar 5, 2026

MelvinBot requested a review from a team March 5, 2026 20:08

MelvinBot mentioned this pull request Mar 5, 2026

[Due for payment 2026-03-16] [$250] Expense-Track expense user can submit to self with unexpected error. #81003

Closed

7 tasks

MelvinBot marked this pull request as ready for review March 5, 2026 20:10

MelvinBot requested a review from a team as a code owner March 5, 2026 20:10

melvin-bot Bot requested review from joekaufmanexpensify and situchan and removed request for a team March 5, 2026 20:10

melvin-bot Bot removed the request for review from a team March 5, 2026 20:10

situchan approved these changes Mar 5, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski March 5, 2026 20:12

mjasikowski approved these changes Mar 6, 2026

View reviewed changes

mjasikowski merged commit 04b333d into main Mar 6, 2026
36 checks passed

mjasikowski deleted the claude-fixSelfDmInSubmitToSomeone branch March 6, 2026 08:17

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

mitarachim mentioned this pull request Mar 9, 2026

Expense-Moving distance map expense to 1:1 shows "moved this expense from self dm" briefly #84530

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass action parameter to participants route when changing recipient#84321

Pass action parameter to participants route when changing recipient#84321
mjasikowski merged 1 commit into
mainfrom
claude-fixSelfDmInSubmitToSomeone

MelvinBot commented Mar 5, 2026

Uh oh!

situchan commented Mar 5, 2026

Uh oh!

melvin-bot Bot commented Mar 5, 2026

Uh oh!

situchan commented Mar 5, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 5, 2026

Uh oh!

codecov Bot commented Mar 5, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MelvinBot commented Mar 5, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

situchan commented Mar 5, 2026

Uh oh!

melvin-bot Bot commented Mar 5, 2026

Uh oh!

situchan commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 5, 2026

Uh oh!

codecov Bot commented Mar 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

situchan commented Mar 5, 2026 •

edited

Loading

codecov Bot commented Mar 5, 2026 •

edited by github-actions Bot

Loading